suiting-young commented on a change in pull request #14823:
URL: https://github.com/apache/airflow/pull/14823#discussion_r595733321
##########
File path: airflow/models/taskinstance.py
##########
@@ -1297,9 +1297,10 @@ def signal_handler(signum, frame): # pylint:
disable=unused-argument
registered = task_copy.register_in_sensor_service(self,
context)
except Exception as e:
self.log.warning(
- "Failed to register in sensor service.Continue to run
task in non smart sensor mode."
+ "Failed to register in sensor service."
+ "Continue to run task in non smart sensor mode.",
+ exc_info=True
)
- self.log.exception(e, exc_info=True)
Review comment:
Generally, I agree with you. It's not acceptable to drop critical
information.
```py
log.warning('descriptive message')
log.exception('critical message') # hide or downgrade this is unacceptable
```
But in these specific situations (*total 6 cases in this PR*),
all of them (*`exception`*) didn't provide useful (*than their `warning`
partners*) information,
but looks really like to **attach** stack trace. I'd believe they are a bit
of misuse.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
