uranusjr commented on a change in pull request #14823:
URL: https://github.com/apache/airflow/pull/14823#discussion_r595797570
##########
File path: airflow/models/taskinstance.py
##########
@@ -1297,9 +1297,10 @@ def signal_handler(signum, frame): # pylint:
disable=unused-argument
registered = task_copy.register_in_sensor_service(self,
context)
except Exception as e:
self.log.warning(
- "Failed to register in sensor service.Continue to run
task in non smart sensor mode."
+ "Failed to register in sensor service."
+ "Continue to run task in non smart sensor mode.",
+ exc_info=True
)
- self.log.exception(e, exc_info=True)
Review comment:
I don’t disagree the current approach is bad. But that does not mean it
is appropriate to change it to
```python
log.warning('descriptive message', exc_info=True)
```
either (it *also* does not mean it is inappropriate). The correct fix may be
```python
log.exception('descriptive message')
```
instead.
I don’t know the answer, so we need a more experienced reviewer on this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
