ashb commented on a change in pull request #14823:
URL: https://github.com/apache/airflow/pull/14823#discussion_r596034802
##########
File path: airflow/providers/amazon/aws/log/s3_task_handler.py
##########
@@ -120,8 +120,9 @@ def _read(self, ti, try_number, metadata=None):
try:
log_exists = self.s3_log_exists(remote_loc)
except Exception as error: # pylint: disable=broad-except
- self.log.exception(error)
- log = f'*** Failed to verify remote log exists
{remote_loc}.\n{str(error)}\n'
+ log = f'*** Failed to verify remote log exists {remote_loc}.'
+ self.log.exception(log)
+ log += f'\n{error}\n'
Review comment:
Slight tweak to this one please (just because the `log` object and the
log message appear in different contexts.)
```suggestion
self.log.exception("Failed to verify remote log exists %s.",
remote_loc)
log = f'*** Failed to verify remote log exists {remote_loc}.'
log += f'\n{error}\n'
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
