SamWheating commented on a change in pull request #15137:
URL: https://github.com/apache/airflow/pull/15137#discussion_r605972319
##########
File path: airflow/kubernetes/pod_launcher.py
##########
@@ -98,6 +98,12 @@ def delete_pod(self, pod: V1Pod):
if e.status != 404:
raise
+ @tenacity.retry(
+ stop=tenacity.stop_after_attempt(3),
+ wait=tenacity.wait_random_exponential(),
+ reraise=True,
+ retry=tenacity.retry_if_exception_type(ApiException),
Review comment:
Ok, I just pushed a commit to only retry on 409 ApiExceptions, let me
know what you think.
Re: the location of this code - it looks like the pod launching code is also
used by the KubernetesExecutor, so if you wanted to move the pod_launcher to
the CNCF provider package you would likely need a copy within the Airflow
package as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
