SamWheating commented on a change in pull request #15137:
URL: https://github.com/apache/airflow/pull/15137#discussion_r606326341



##########
File path: airflow/kubernetes/pod_launcher.py
##########
@@ -98,6 +98,12 @@ def delete_pod(self, pod: V1Pod):
             if e.status != 404:
                 raise
 
+    @tenacity.retry(
+        stop=tenacity.stop_after_attempt(3),
+        wait=tenacity.wait_random_exponential(),
+        reraise=True,
+        retry=tenacity.retry_if_exception_type(ApiException),

Review comment:
       Yeah, I just looked a little more and it appears that you're right. Its 
probably not too big of a change then to move a subset of the pod_launcher file 
into the cncf provider package and update some imports and such, and I'd 
definitely be interested in helping with that / taking that on. Would you like 
to write up an issue for that, or shall I?
   
   Regarding the issue in question, would you be OK with reviewing/merging this 
PR in the meantime? A larger refactor might take a while to get properly 
reviewed and this issue is causing a lot of failures on our end.   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to