SamWheating opened a new pull request #15137:
URL: https://github.com/apache/airflow/pull/15137


   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   closes: https://github.com/apache/airflow/issues/15097
   
   Adding retries to handle Kubernetes API Exceptions while trying to start a 
pod. 
   
   I've opted for a random exponential backoff since the issues we've been 
seeing have been the result of too many simultaneous requests, so using a retry 
without jitter could lead to just repeating the same race conditions over and 
over. 
   
   This will also retry in the event of _any_ kubernetes API Error. Is this 
alright? If we want to reduce the scope to just 409 errors as described in the 
linked issue its pretty easy to do so using tenacity's 
`retry=retry_if_exception(predicate)` functionality. 
   
   I'll try to run some experiments this morning to replicate the original 
issue and confirm that this fixes things. 
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to