mik-laj commented on a change in pull request #15013:
URL: https://github.com/apache/airflow/pull/15013#discussion_r615969275
##########
File path: airflow/providers/hashicorp/secrets/vault.py
##########
@@ -18,8 +18,10 @@
"""Objects relating to sourcing connections & variables from Hashicorp Vault"""
from typing import Optional
+from airflow.models.connection import Connection
from airflow.providers.hashicorp._internal_client.vault_client import
_VaultClient # noqa
from airflow.secrets import BaseSecretsBackend
+from airflow.secrets.local_filesystem import _create_connection
Review comment:
I have the impression that we have managed to reach a consensus. This
change will be in the next provider package after Airflow 2.1 is released.
There is a slight problem with the provider packages releases process. We
always release providers packages from the main branch, so we cannot merge this
PR until we release Airflow 2.1 and we will start releasing providers packages
that will be compatible with this version.
In the meantime, we can create a new public method that will create
connections from the dictionary. This method will be released in Airflow 2.1.
https://github.com/apache/airflow/pull/15425
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
