mik-laj commented on a change in pull request #15013:
URL: https://github.com/apache/airflow/pull/15013#discussion_r613750962
##########
File path: airflow/providers/hashicorp/secrets/vault.py
##########
@@ -18,8 +18,10 @@
"""Objects relating to sourcing connections & variables from Hashicorp Vault"""
from typing import Optional
+from airflow.models.connection import Connection
from airflow.providers.hashicorp._internal_client.vault_client import
_VaultClient # noqa
from airflow.secrets import BaseSecretsBackend
+from airflow.secrets.local_filesystem import _create_connection
Review comment:
Yes. Exactly.
We should discuss the approach on the mailing list and choose the best
solution that everyone accepts. I personally think that we should mark this
package as only supported by Airflow 2.1, because trying to maintain backward
compatibility will limit our development possibilities. It should be normal for
users that new packages/library versions may require a core version if we add
new features. See:
https://lists.apache.org/thread.html/r713f180120d0a39b53567812eb5db34f992ec81979818d2175598b71%40%3Cdev.airflow.apache.org%3E
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
