mik-laj commented on a change in pull request #15100:
URL: https://github.com/apache/airflow/pull/15100#discussion_r606723464
##########
File path: tests/secrets/test_local_filesystem.py
##########
@@ -222,9 +222,9 @@ def test_missing_file(self, mock_exists):
{
"conn_a": "mysql://hosta",
"conn_b": ''.join(
Review comment:
The extra__google_cloud_platform__keyfile_dict hey should contain JSON
as a string, so I think we can generate URL in old-way. We have only string as
a extra fields value.
##########
File path: tests/secrets/test_local_filesystem.py
##########
@@ -222,9 +222,9 @@ def test_missing_file(self, mock_exists):
{
"conn_a": "mysql://hosta",
"conn_b": ''.join(
Review comment:
The extra__google_cloud_platform__keyfile_dict hey should contain JSON
as a string, so I think we can generate URL in old-way. We have only string as
a extra fields values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
