dstandish commented on a change in pull request #15100:
URL: https://github.com/apache/airflow/pull/15100#discussion_r606724456



##########
File path: tests/secrets/test_local_filesystem.py
##########
@@ -222,9 +222,9 @@ def test_missing_file(self, mock_exists):
                 {
                     "conn_a": "mysql://hosta",
                     "conn_b": ''.join(

Review comment:
       > The extra__google_cloud_platform__keyfile_dict hey should contain JSON 
as a string
   That is true, but your yaml example does not do this. The problem is the way 
you defined the yaml.  You need to put it as a string and not as an object if 
you want local filesystem backend to parse it as such.

##########
File path: tests/secrets/test_local_filesystem.py
##########
@@ -222,9 +222,9 @@ def test_missing_file(self, mock_exists):
                 {
                     "conn_a": "mysql://hosta",
                     "conn_b": ''.join(

Review comment:
       > The extra__google_cloud_platform__keyfile_dict hey should contain JSON 
as a string
   
   That is true, but your yaml example does not do this. The problem is the way 
you defined the yaml.  You need to put it as a string and not as an object if 
you want local filesystem backend to parse it as such.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to