dstandish commented on a change in pull request #15100:
URL: https://github.com/apache/airflow/pull/15100#discussion_r606725200



##########
File path: tests/secrets/test_local_filesystem.py
##########
@@ -222,9 +222,9 @@ def test_missing_file(self, mock_exists):
                 {
                     "conn_a": "mysql://hosta",
                     "conn_b": ''.join(

Review comment:
       > so I think we can generate URL in old-way. 
   
   if you change your yaml so that `extra__google_cloud_platform__keyfile_dict` 
is a string and not an object, then it's true the generated URI would be 
old-style.  but since it's not like that it was forced to use new style.
   
   > We have only string as a extra fields values 
   
   not true, you defined object there in the yaml




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to