potiuk commented on a change in pull request #15533:
URL: https://github.com/apache/airflow/pull/15533#discussion_r620481685
##########
File path: airflow/providers/snowflake/hooks/snowflake.py
##########
@@ -245,3 +247,40 @@ def set_autocommit(self, conn, autocommit: Any) -> None:
def get_autocommit(self, conn):
return getattr(conn, 'autocommit_mode', False)
+
Review comment:
There are two thigns I do not like here:
1) Copying the logic of the DBApi run() method. I do not think however we
can do too much about it though, because we do not want to modify the DBApi
internals and make the provider depends on future version of Airflow.. So not
much we can do here.
2) We only store LAST query id even if we execute a sequence of queries. I
think we should keep an array of those. rather than overwrite the query id with
the last one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
