potiuk commented on a change in pull request #15533:
URL: https://github.com/apache/airflow/pull/15533#discussion_r620575029
##########
File path: airflow/providers/snowflake/hooks/snowflake.py
##########
@@ -245,3 +247,40 @@ def set_autocommit(self, conn, autocommit: Any) -> None:
def get_autocommit(self, conn):
return getattr(conn, 'autocommit_mode', False)
+
Review comment:
We could potentially add some "callbacks" in the DBHook implementation,
but this would mean Airflow 2.1+ compatibility. I am not sure it's worth it.
Maybe we could figure out some ways of doing back-compatibility and implement
it "properly" (like copying the method but use calbacks/original run with
callbacks() when available? But I am not sure if it is worth it either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
