mobuchowski commented on a change in pull request #15533:
URL: https://github.com/apache/airflow/pull/15533#discussion_r620693233
##########
File path: airflow/providers/snowflake/hooks/snowflake.py
##########
@@ -245,3 +247,40 @@ def set_autocommit(self, conn, autocommit: Any) -> None:
def get_autocommit(self, conn):
return getattr(conn, 'autocommit_mode', False)
+
Review comment:
That could possibly allow native
[OpenLineage](https://github.com/OpenLineage/OpenLineage) integration in
airflow, but that's separate topic :slightly_smiling_face:
>Maybe we could figure out some ways of doing back-compatibility and
implement it "properly" (like copying the method but use calbacks/original run
with callbacks() when available?
Yes. that makes sense - there's a lot of metadata that some databases expose
in a non standard way. One example is `BigQueryExecuteQueryOperator`, which
puts job id into xcoms.
For now, I don't think exposing query id in this particular way in this
particular provider will make it in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
