khilawar4 commented on pull request #15727: URL: https://github.com/apache/airflow/pull/15727#issuecomment-840816231
> Overall the code looks good, thanks for the contribution! > > But can you please standardize the updates to the operator doc strings? The issues I have with them are: > > 1. You're using different text between the operators. > 2. The way you've phrased the doc string is as if it is a git commit or a message to the reviewer: ` "adding this param to template_fields so that..."` this type of present participle doesn't read well after the fact. > 3. Many times you've added the text body below the `type` line instead of updating the existing `param` line. > > I propose you just update the existing doc string for this attribute. For example most of them currently read like: > > > param aws_conn_id: aws connection to use > > I propose you update them like so: > > > param aws_conn_id: aws connection to use. **This param can also be overridden using DAG Jinja templating.** sorry about the confusion. updated the requested changes again. please validate and let me know if anything is missed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
