o-nikolas commented on a change in pull request #15727:
URL: https://github.com/apache/airflow/pull/15727#discussion_r632325644
##########
File path: airflow/providers/amazon/aws/operators/athena.py
##########
@@ -38,8 +38,8 @@ class AWSAthenaOperator(BaseOperator):
:type database: str
:param output_location: s3 path to write the query results into.
(templated)
:type output_location: str
- :param aws_conn_id: aws connection to use
- :type aws_conn_id: <str> adding this param to template_fields so that it
can be overriden using jinja template from Dags
+ :param aws_conn_id: Aws connection to use in template_fields so that it
can be overriden using jinja template from Dags.
+ :type aws_conn_id: <str>
Review comment:
Can you please undo your changes to the type field? You've added carets
but this is not done elsewhere in the code.
##########
File path: airflow/providers/amazon/aws/operators/athena.py
##########
@@ -38,8 +38,8 @@ class AWSAthenaOperator(BaseOperator):
:type database: str
:param output_location: s3 path to write the query results into.
(templated)
:type output_location: str
- :param aws_conn_id: aws connection to use
- :type aws_conn_id: <str> adding this param to template_fields so that it
can be overriden using jinja template from Dags
+ :param aws_conn_id: Aws connection to use in template_fields so that it
can be overriden using jinja template from Dags.
+ :type aws_conn_id: <str>
Review comment:
Please update all other occurrences.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
