khilawar4 commented on pull request #15727:
URL: https://github.com/apache/airflow/pull/15727#issuecomment-844582799


   > > This PR is to pass the Connection_ID value to the operator as part of 
XCom variable dynamically. (I am creating the airflow connection (i am giving 
the airflow connection name as `$run_id+$dag_id`) using my plugin and inserting 
the connection_id name in Xcom variable so that dag remaining steps can use the 
connection_id name from XCOM variable.
   > 
   > This explains why you need the templating for your flow but it doesn't 
explain the logic behind this flow.
   > Can you please elaborate on the part of why are you doing it? Why do you 
need each run to use a different and unique connection?
   
   i am deleting old connection creating the new connection for that dag with 
the name `$run_id+$dag_id` so that other dag users will not be able to predict 
the  connection name to use in their dags. With this approach i will have dag 
isolation.
   
   more over , is there any issue if `aws_conn_id` is part of 
`templated_fields` ? 
   i feel it will give more flexibility to user to use jinja template to fetch 
dynamic names for airflow connection id or some other xcom variables. 
   
   please let me know if above explanation helps to move forward to merge this 
PR.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to