msumit opened a new pull request #16233: URL: https://github.com/apache/airflow/pull/16233
This is to fix the issue https://github.com/apache/airflow/issues/15234. As of now, TI success & failure endpoints are POST only and behave differently as per the `confirmed` flag. They either render a confirmation page or updates the TI states on the basis of that flag, something which is not a great design. Also, as these endpoints are POST only, they throw a 404 error when someone clicks on the link received via email. To fix the issue, extracting the rendering functionalities into a diff endpoint `/confirm` & keeping these endpoints as pure POST endpoints. If the approach looks good, I can work on testcases later. <!-- Thank you for contributing! Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping committers for the review! In case of existing issue, reference it using one of the following: closes: #ISSUE related: #ISSUE How to write a good git commit message: http://chris.beams.io/posts/git-commit/ --> --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information. In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
