msumit commented on a change in pull request #16233:
URL: https://github.com/apache/airflow/pull/16233#discussion_r644637354
##########
File path: airflow/www/views.py
##########
@@ -1804,53 +1802,86 @@ def _mark_task_instance_state( # pylint:
disable=too-many-arguments
latest_execution_date = dag.get_latest_execution_date()
if not latest_execution_date:
flash(f"Cannot make {state}, seem that dag {dag_id} has never
run", "error")
- return redirect(origin)
+ return redirect(request.referrer)
Review comment:
@ashb this is inside the POST call, so the only way to hit this endpoint
via the confirm page.. so in that case, the referrer should be always available?
##########
File path: airflow/www/templates/airflow/ti_confirm.html
##########
@@ -0,0 +1,39 @@
+{#
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+#}
+
+{% extends base_template %}
+
+{% block content %}
Review comment:
1 major change - provision for the action endpoint i.e. `success` or
`failed`
1 minor change - got rid of hideen confirmation input., though no harm in
keeping it.
##########
File path: airflow/www/templates/airflow/ti_confirm.html
##########
@@ -0,0 +1,39 @@
+{#
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+#}
+
+{% extends base_template %}
+
+{% block content %}
Review comment:
sorry, another major change is that the iteration is happening on
`request.args.items` instead of `request.form.items`
##########
File path: airflow/www/views.py
##########
@@ -1804,53 +1802,86 @@ def _mark_task_instance_state( # pylint:
disable=too-many-arguments
latest_execution_date = dag.get_latest_execution_date()
if not latest_execution_date:
flash(f"Cannot make {state}, seem that dag {dag_id} has never
run", "error")
- return redirect(origin)
+ return redirect(request.referrer)
Review comment:
Ok, brought the `origin` back. In case someone is clicking it via an
email link, then after the operation, it loads the home page, which is fine in
my opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
