msumit commented on a change in pull request #16233:
URL: https://github.com/apache/airflow/pull/16233#discussion_r644753339



##########
File path: airflow/www/views.py
##########
@@ -1804,53 +1802,86 @@ def _mark_task_instance_state(  # pylint: 
disable=too-many-arguments
         latest_execution_date = dag.get_latest_execution_date()
         if not latest_execution_date:
             flash(f"Cannot make {state}, seem that dag {dag_id} has never 
run", "error")
-            return redirect(origin)
+            return redirect(request.referrer)

Review comment:
       Ok, brought the `origin` back. In case someone is clicking it via an 
email link, then after the operation, it loads the home page, which is fine in 
my opinion. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to