jedcunningham commented on a change in pull request #16291:
URL: https://github.com/apache/airflow/pull/16291#discussion_r646597798
##########
File path: chart/templates/jobs/migrate-database-job.yaml
##########
@@ -38,6 +38,9 @@ metadata:
"helm.sh/hook": post-install,post-upgrade
"helm.sh/hook-weight": "1"
"helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded
+ "argocd.argoproj.io/hook": Sync
+ "argocd.argoproj.io/sync-wave": "0"
+ "argocd.argoproj.io/hook-delete-policy": BeforeHookCreation,HookSucceeded
Review comment:
Yeah, I'd prefer to expose extraAnnotations for these jobs rather than
add in specific annotations for a specific platform. @dnskr, something you want
to tackle?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
