jedcunningham commented on a change in pull request #16291:
URL: https://github.com/apache/airflow/pull/16291#discussion_r646655643
##########
File path: chart/templates/jobs/migrate-database-job.yaml
##########
@@ -38,6 +38,9 @@ metadata:
"helm.sh/hook": post-install,post-upgrade
"helm.sh/hook-weight": "1"
"helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded
+ "argocd.argoproj.io/hook": Sync
+ "argocd.argoproj.io/sync-wave": "0"
+ "argocd.argoproj.io/hook-delete-policy": BeforeHookCreation,HookSucceeded
Review comment:
Yeah, I'll get a PR in today, no worries. Thanks for the detailed
explanation btw!
@kaxil, I feel like we should toss this into the docs somewhere, maybe a new
page with platform/tool-specific notes? Beats expecting folks to hit google and
sift through PRs. Let me know if you have a preference on naming.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
