dnskr commented on a change in pull request #16291:
URL: https://github.com/apache/airflow/pull/16291#discussion_r646783130
##########
File path: chart/templates/jobs/migrate-database-job.yaml
##########
@@ -38,6 +38,9 @@ metadata:
"helm.sh/hook": post-install,post-upgrade
"helm.sh/hook-weight": "1"
"helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded
+ "argocd.argoproj.io/hook": Sync
+ "argocd.argoproj.io/sync-wave": "0"
+ "argocd.argoproj.io/hook-delete-policy": BeforeHookCreation,HookSucceeded
Review comment:
@jedcunningham In the PR
[#16058](https://github.com/apache/airflow/pull/16058) you have added
annotations on Pod level, but they are needed on Job level.
So the same as
[this](https://github.com/apache/airflow/blob/main/chart/templates/jobs/migrate-database-job.yaml#L53-L55)
piece of code but
[here](https://github.com/apache/airflow/blob/main/chart/templates/jobs/migrate-database-job.yaml#L37)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
