eladkal commented on a change in pull request #16676:
URL: https://github.com/apache/airflow/pull/16676#discussion_r659195337
##########
File path: airflow/hooks/dbapi.py
##########
@@ -211,8 +211,13 @@ def _run_command(self, cur, sql_statement, parameters):
self.log.info("Running statement: %s, parameters: %s", sql_statement,
parameters)
if parameters:
cur.execute(sql_statement, parameters)
+ res = cur.fetchall()
+ result={'sql_statement': res,'headers': list(map(lambda t: t[0],
cur.description))}
+ self.log.info("Query Results: %s", result)
Review comment:
What kind of query do you run that this change is needed?
In ETLs most queries that you run are DMLs (insert, update, delete, etc..)
these statments return 1 row.
I think you are running DQL (select) which is a bit odd?
My question here is if this change is needed and if so why not using
fetchone?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
