potiuk commented on a change in pull request #16676:
URL: https://github.com/apache/airflow/pull/16676#discussion_r659207277
##########
File path: airflow/hooks/dbapi.py
##########
@@ -211,8 +211,13 @@ def _run_command(self, cur, sql_statement, parameters):
self.log.info("Running statement: %s, parameters: %s", sql_statement,
parameters)
if parameters:
cur.execute(sql_statement, parameters)
+ res = cur.fetchall()
+ result={'sql_statement': res,'headers': list(map(lambda t: t[0],
cur.description))}
+ self.log.info("Query Results: %s", result)
Review comment:
AFAIK - fetchall has no effect on DQK/DDL queries :). But I agree for
DQL queries it can have disastrous consequences by fetching all data to memory.
But IMHO this is not a a problem - it's expected that when you debug, you can
run out of memory or things will start running slower etc. I do not think
fetchall changes the actual semantics of what happens with the results, so
memory/time needed to fetch the records should be the only side-effect (but
also that's why it should only run when debug level is effective for the logger:
```
if self.log.isEnabledFor(logging.DEBUG):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
