potiuk commented on a change in pull request #16676:
URL: https://github.com/apache/airflow/pull/16676#discussion_r659203553
##########
File path: airflow/hooks/dbapi.py
##########
@@ -211,8 +211,13 @@ def _run_command(self, cur, sql_statement, parameters):
self.log.info("Running statement: %s, parameters: %s", sql_statement,
parameters)
if parameters:
cur.execute(sql_statement, parameters)
+ res = cur.fetchall()
+ result={'sql_statement': res,'headers': list(map(lambda t: t[0],
cur.description))}
+ self.log.info("Query Results: %s", result)
Review comment:
Just a comment to what @eladkal wrote. It's not entirely correc. I think
the DML mostly is pretty valid for the operators. But we do not actually
prevent people to run the DQL queries, via Hooks. It's no problem whatsoever to
build your custom operator to use two hooks and pass the DQL'ed data with some
manipulation to another hook. This is what most transfer operators do.
That's why I think having debug level to show the results is pretty useful
when you iterate and test your custom operators.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
