kaxil commented on a change in pull request #17719:
URL: https://github.com/apache/airflow/pull/17719#discussion_r692997854
##########
File path: airflow/jobs/backfill_job.py
##########
@@ -645,16 +645,14 @@ def tabulate_ti_keys_set(set_ti_keys:
Set[TaskInstanceKey]) -> str:
# Sorting by execution date first
sorted_ti_keys = sorted(
set_ti_keys,
- key=lambda ti_key: (ti_key.execution_date, ti_key.dag_id,
ti_key.task_id, ti_key.try_number),
+ key=lambda ti_key: (ti_key.run_id, ti_key.dag_id,
ti_key.task_id, ti_key.try_number),
)
return tabulate(sorted_ti_keys, headers=["DAG ID", "Task ID",
"Execution date", "Try number"])
def tabulate_tis_set(set_tis: Set[TaskInstance]) -> str:
# Sorting by execution date first
- sorted_tis = sorted(
- set_tis, key=lambda ti: (ti.execution_date, ti.dag_id,
ti.task_id, ti.try_number)
- )
- tis_values = ((ti.dag_id, ti.task_id, ti.execution_date,
ti.try_number) for ti in sorted_tis)
+ sorted_tis = sorted(set_tis, key=lambda ti: (ti.run_id, ti.dag_id,
ti.task_id, ti.try_number))
+ tis_values = ((ti.dag_id, ti.task_id, ti.run_id, ti.try_number)
for ti in sorted_tis)
Review comment:
Would be good to keep ordering by `execution_date` or even `start_date`,
run_id feels odds for sorting here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
