SamWheating commented on a change in pull request #17121:
URL: https://github.com/apache/airflow/pull/17121#discussion_r705882789
##########
File path: airflow/dag_processing/processor.py
##########
@@ -645,3 +648,12 @@ def process_file(
self.log.exception("Error logging import errors!")
return len(dagbag.dags), len(dagbag.import_errors)
+
+ def _deactivate_missing_dags(self, session: Session, dagbag: DagBag,
file_path: str) -> None:
+ deactivated = (
+ session.query(DagModel)
+ .filter(DagModel.fileloc == file_path, DagModel.is_active,
~DagModel.dag_id.in_(dagbag.dag_ids))
+ .update({DagModel.is_active: False}, synchronize_session="fetch")
+ )
+ if deactivated:
+ self.log.info("Deactivated %i DAGs which are no longer present in
%s", deactivated, file_path)
Review comment:
> I am touching same code, to do something similar (though not same at
#18120)
Interesting, I'll follow along with that PR as well, I think that there's
some overlap in the function of that PR and this one, but I think there's room
for both.
There's also another PR recently open which takes a different approach to
the same problem (https://github.com/apache/airflow/pull/18087) We should
definitely compare the different approaches and agree upon the best way to fix
this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
