SamWheating commented on a change in pull request #17121:
URL: https://github.com/apache/airflow/pull/17121#discussion_r711414411
##########
File path: airflow/dag_processing/processor.py
##########
@@ -645,3 +648,12 @@ def process_file(
self.log.exception("Error logging import errors!")
return len(dagbag.dags), len(dagbag.import_errors)
+
+ def _deactivate_missing_dags(self, session: Session, dagbag: DagBag,
file_path: str) -> None:
+ deactivated = (
+ session.query(DagModel)
+ .filter(DagModel.fileloc == file_path, DagModel.is_active,
~DagModel.dag_id.in_(dagbag.dag_ids))
+ .update({DagModel.is_active: False}, synchronize_session="fetch")
+ )
+ if deactivated:
+ self.log.info("Deactivated %i DAGs which are no longer present in
%s", deactivated, file_path)
Review comment:
So I just went to go and make the requested changes and it doesn't look
like `update().returning()` is supported in the SqlAlchemy query API but only
in direct table operations.
https://docs.sqlalchemy.org/en/14/core/dml.html#sqlalchemy.sql.expression.Update.returning
I'm not an expert in SqlAlchemy, but it looks like we use the ORM-friendly
`session.query().update()` methods everywhere, in which case we can't use
`.returning()`
Does my understanding sound correct? If so then we'll have to just mark this
one as resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
