mik-laj commented on a change in pull request #18362:
URL: https://github.com/apache/airflow/pull/18362#discussion_r711800393
##########
File path: scripts/ci/docker-compose/backend-mssql.yml
##########
@@ -20,12 +20,12 @@ services:
airflow:
environment:
- BACKEND=mssql
- -
AIRFLOW__CORE__SQL_ALCHEMY_CONN=mssql+pyodbc://sa:Airflow123@mssql:1433/master?driver=ODBC+Driver+17+for+SQL+Server
- -
AIRFLOW__CELERY__RESULT_BACKEND=db+mssql+pyodbc://sa:Airflow123@mssql:1433/master?driver=ODBC+Driver+17+for+SQL+Server
+ -
AIRFLOW__CORE__SQL_ALCHEMY_CONN=mssql+pyodbc://sa:Airflow123@mssql:1433/airflow?driver=ODBC+Driver+17+for+SQL+Server
+ -
AIRFLOW__CELERY__RESULT_BACKEND=db+mssql+pyodbc://sa:Airflow123@mssql:1433/airflow?driver=ODBC+Driver+17+for+SQL+Server
- AIRFLOW__CORE__EXECUTOR=LocalExecutor
depends_on:
- mssql:
- condition: service_healthy
+ - mssqlsetup
Review comment:
What do you think about add condition - `service_completed_successfully`?
https://github.com/apache/airflow/blob/14b3e66ad5e2325eb2ee7b9c6661ff7b636d017d/docs/apache-airflow/start/docker-compose.yaml#L114-L115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
