potiuk commented on a change in pull request #18362:
URL: https://github.com/apache/airflow/pull/18362#discussion_r711802537
##########
File path: scripts/ci/docker-compose/backend-mssql.yml
##########
@@ -20,12 +20,12 @@ services:
airflow:
environment:
- BACKEND=mssql
- -
AIRFLOW__CORE__SQL_ALCHEMY_CONN=mssql+pyodbc://sa:Airflow123@mssql:1433/master?driver=ODBC+Driver+17+for+SQL+Server
- -
AIRFLOW__CELERY__RESULT_BACKEND=db+mssql+pyodbc://sa:Airflow123@mssql:1433/master?driver=ODBC+Driver+17+for+SQL+Server
+ -
AIRFLOW__CORE__SQL_ALCHEMY_CONN=mssql+pyodbc://sa:Airflow123@mssql:1433/airflow?driver=ODBC+Driver+17+for+SQL+Server
+ -
AIRFLOW__CELERY__RESULT_BACKEND=db+mssql+pyodbc://sa:Airflow123@mssql:1433/airflow?driver=ODBC+Driver+17+for+SQL+Server
- AIRFLOW__CORE__EXECUTOR=LocalExecutor
depends_on:
- mssql:
- condition: service_healthy
+ - mssqlsetup
Review comment:
I do not know basically how to make dependency on two services - one
with a condition and one without - it does not seem to be supported to depend
on one service that has no condition and another service that depends on "just
service" - the first one requires dict, the second list, but I could not find a
way how to make both work.
that 's why I made `airflow` depends on both mssql and mssqlsetup
(unconditionally) but also make mssqlsetup depends conditionally on healthy
status of mssql
I think it does the job nicely - but if you can find a better solution - I
am all ears.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
