mik-laj commented on a change in pull request #18362:
URL: https://github.com/apache/airflow/pull/18362#discussion_r711802455
##########
File path: scripts/ci/docker-compose/backend-mssql.yml
##########
@@ -20,12 +20,12 @@ services:
airflow:
environment:
- BACKEND=mssql
- -
AIRFLOW__CORE__SQL_ALCHEMY_CONN=mssql+pyodbc://sa:Airflow123@mssql:1433/master?driver=ODBC+Driver+17+for+SQL+Server
- -
AIRFLOW__CELERY__RESULT_BACKEND=db+mssql+pyodbc://sa:Airflow123@mssql:1433/master?driver=ODBC+Driver+17+for+SQL+Server
+ -
AIRFLOW__CORE__SQL_ALCHEMY_CONN=mssql+pyodbc://sa:Airflow123@mssql:1433/airflow?driver=ODBC+Driver+17+for+SQL+Server
+ -
AIRFLOW__CELERY__RESULT_BACKEND=db+mssql+pyodbc://sa:Airflow123@mssql:1433/airflow?driver=ODBC+Driver+17+for+SQL+Server
- AIRFLOW__CORE__EXECUTOR=LocalExecutor
depends_on:
- mssql:
- condition: service_healthy
+ - mssqlsetup
Review comment:
By using this condition, the container will not be started until another
container is stopped, so you can do additional initiations steps before running
the main container, e.g. initialize the database, get dependencies and then
start the main container.
Here are docs about it:
https://github.com/compose-spec/compose-spec/blob/master/spec.md#long-syntax-1
This is supported starting with the 1.29.0 (2021-04-06) version.
https://docs.docker.com/compose/release-notes/#1290
Here is another real-life example with node app:
https://github.com/KlubJagiellonski/pola-web/blob/8c93e0b79231c2b92a984099df3209e287ac9458/docker-compose.yaml#L17-L18
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
