potiuk commented on a change in pull request #18362:
URL: https://github.com/apache/airflow/pull/18362#discussion_r711957503
##########
File path: tests/core/test_sqlalchemy_config.py
##########
@@ -77,7 +77,7 @@ def test_sql_alchemy_connect_args(
with conf_vars(config):
settings.configure_orm()
engine_args = {}
- if settings.SQL_ALCHEMY_CONN.startswith('mysql'):
+ if settings.SQL_ALCHEMY_CONN.startswith('mysql') or
settings.SQL_ALCHEMY_CONN.startswith('mssql'):
Review comment:
TIL! Thanks. i had no idea, it's just one sentence in the docs
mentioning it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
