uranusjr commented on a change in pull request #19097:
URL: https://github.com/apache/airflow/pull/19097#discussion_r732918565



##########
File path: airflow/jobs/scheduler_job.py
##########
@@ -529,6 +529,17 @@ def _process_executor_events(self, session: Session = 
None) -> int:
                 self.log.info("Setting external_id for %s to %s", ti, info)
                 continue
 
+            msg = ("TaskInstance Finished: dag_id=%s, task_id=%s, run_id=%s, "
+                   "run_start_time=%f, run_end_time=%f, "
+                   "run_duration=%f, state=%s, executor_state=%s, 
try_number=%d, max_tries=%d, job_id=%d, "
+                   "pool=%s, queue=%s, priority_weight=%d, operator=%s"
+            )
+            self.log.info(msg, ti.dag_id, ti.task_id, ti.run_id,
+                          ti.start_date.timestamp() if ti.start_date is not 
None else 0,
+                          ti.end_date.timestamp() if ti.end_date is not None 
else 0,

Review comment:
       It's OK to change the labels, but maybe `run_start_date` would be 
better? (I don't like using *date* here but it's more consistent to other parts 
of the code base)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to