steveyz-astro commented on a change in pull request #19097:
URL: https://github.com/apache/airflow/pull/19097#discussion_r734242942
##########
File path: airflow/models/dagrun.py
##########
@@ -526,6 +526,28 @@ def update_state(
else:
self.set_state(State.RUNNING)
+ if self.get_state() == State.FAILED or self.get_state() ==
State.SUCCESS:
Review comment:
it doesn't appear to cover all of the cases. e.g.
` except AirflowException as e:
if not test_mode:
self.refresh_from_db(lock_for_update=True, session=session)
# for case when task is marked as success/failed externally
# or dagrun timed out and task is marked as skipped
# current behavior doesn't hit the callbacks
if self.state in State.finished:
return
else:`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
