uranusjr commented on a change in pull request #19097:
URL: https://github.com/apache/airflow/pull/19097#discussion_r734225901
##########
File path: airflow/models/dagrun.py
##########
@@ -526,6 +526,28 @@ def update_state(
else:
self.set_state(State.RUNNING)
+ if self.get_state() == State.FAILED or self.get_state() ==
State.SUCCESS:
Review comment:
Thanks, the reasoning makes sense. In that case, would it be possible to
move the TaskInstance logging to a similar abstraction level, instead of doing
it in SchedulerJob? Or does the TI lack such abstraction to do the same? I see
there's a `TaskInstance._log_state()` function, which is called (for SUCCESS
and FAILURE states) in `_run_raw_task`, but this new log seems to be emitted at
a difference place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
