steveyz-astro commented on a change in pull request #19097:
URL: https://github.com/apache/airflow/pull/19097#discussion_r734609091
##########
File path: airflow/models/dagrun.py
##########
@@ -526,6 +526,28 @@ def update_state(
else:
self.set_state(State.RUNNING)
+ if self.get_state() == State.FAILED or self.get_state() ==
State.SUCCESS:
Review comment:
I'd prefer not to make major changes to code flow just for the
additional logging. doesn't seem the worth the risk tradeoff of potentially
breaking existing behavior. It seems like there are a lot of edge conditions
in terms of error/skipping handling in this code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
