potiuk commented on a change in pull request #19189:
URL: https://github.com/apache/airflow/pull/19189#discussion_r735536523
##########
File path: Dockerfile
##########
@@ -211,19 +214,28 @@ ENV
AIRFLOW_PRE_CACHED_PIP_PACKAGES=${AIRFLOW_PRE_CACHED_PIP_PACKAGES} \
AIRFLOW_SOURCES_FROM=${AIRFLOW_SOURCES_FROM} \
AIRFLOW_SOURCES_TO=${AIRFLOW_SOURCES_TO}
+# Copy all scripts required for installation - changing any of those should
lead to
+# rebuilding from here
+COPY scripts/docker/*.sh /scripts/docker/
+
# In case of Production build image segment we want to pre-install main
version of airflow
# dependencies from GitHub so that we do not have to always reinstall it from
the scratch.
# The Airflow (and providers in case INSTALL_PROVIDERS_FROM_SOURCES is "false")
# are uninstalled, only dependencies remain
# the cache is only used when "upgrade to newer dependencies" is not set to
automatically
# account for removed dependencies (we do not install them in the first place)
# Upgrade to specific PIP version
-RUN bash /scripts/docker/install_pip_version.sh; \
+RUN bash /scripts/docker/create_venv.sh; \
+ export PATH=/.venv/bin:${PATH}; \
Review comment:
Yeah. You are both right - the first one is wrong (I did not notice it
was reversed). That actually explains why I did not work when I created venv
first and I added it additionally after create_env :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
