potiuk commented on a change in pull request #19189:
URL: https://github.com/apache/airflow/pull/19189#discussion_r735578611
##########
File path: Dockerfile
##########
@@ -183,16 +183,19 @@ ENV INSTALL_MYSQL_CLIENT=${INSTALL_MYSQL_CLIENT} \
AIRFLOW_CONSTRAINTS_REFERENCE=${AIRFLOW_CONSTRAINTS_REFERENCE} \
AIRFLOW_CONSTRAINTS_LOCATION=${AIRFLOW_CONSTRAINTS_LOCATION} \
DEFAULT_CONSTRAINTS_BRANCH=${DEFAULT_CONSTRAINTS_BRANCH} \
- PATH=${PATH}:/root/.local/bin \
+ PATH=${PATH}:/.venv/bin \
AIRFLOW_PIP_VERSION=${AIRFLOW_PIP_VERSION} \
Review comment:
I actually reviewed those envs and found one problem that haunted me.
It was a bit different problem but I had a bit TOO many variables put
together (not the PATH though). I also had merged COMMIT_ID and BUILD_ID in
the final PROD image in the same env variables and the result was that when I
was testing and building the image, it did not use cache as much as it could
leading to slower rebuild times (new commit_id basically always invalidated
almost all image and resulted in installing all apt dependencies every time I
added a new commit - whcih was quite unnecessary. I fixed in the last push -
good that that you raised my attentiion to it @mik-laj !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
