potiuk commented on a change in pull request #19189:
URL: https://github.com/apache/airflow/pull/19189#discussion_r735538585
##########
File path: Dockerfile
##########
@@ -183,16 +183,19 @@ ENV INSTALL_MYSQL_CLIENT=${INSTALL_MYSQL_CLIENT} \
AIRFLOW_CONSTRAINTS_REFERENCE=${AIRFLOW_CONSTRAINTS_REFERENCE} \
AIRFLOW_CONSTRAINTS_LOCATION=${AIRFLOW_CONSTRAINTS_LOCATION} \
DEFAULT_CONSTRAINTS_BRANCH=${DEFAULT_CONSTRAINTS_BRANCH} \
- PATH=${PATH}:/root/.local/bin \
+ PATH=${PATH}:/.venv/bin \
AIRFLOW_PIP_VERSION=${AIRFLOW_PIP_VERSION} \
Review comment:
I used to have them separate but his is mainly because of optimisations
which are recommended (and I think you also pointed it out once :) ).
Running multiple ENV entries in Dockerfile might be slower and leads to more
layers, That's why it is recommended to group them together. In some cases it
can actually add couple of seconds (!) to add one more line with ENV, so I
prefer to group them rather than split in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
