mik-laj commented on a change in pull request #19189:
URL: https://github.com/apache/airflow/pull/19189#discussion_r737970047
##########
File path: Dockerfile
##########
@@ -183,16 +183,19 @@ ENV INSTALL_MYSQL_CLIENT=${INSTALL_MYSQL_CLIENT} \
AIRFLOW_CONSTRAINTS_REFERENCE=${AIRFLOW_CONSTRAINTS_REFERENCE} \
AIRFLOW_CONSTRAINTS_LOCATION=${AIRFLOW_CONSTRAINTS_LOCATION} \
DEFAULT_CONSTRAINTS_BRANCH=${DEFAULT_CONSTRAINTS_BRANCH} \
- PATH=${PATH}:/root/.local/bin \
+ PATH=${PATH}:/.venv/bin \
AIRFLOW_PIP_VERSION=${AIRFLOW_PIP_VERSION} \
Review comment:
In the following code block, we need only two variables:
`INSTALL_MYSQL_CLIENT`, `INSTALL_MSSQL_CLIENT`
https://github.com/apache/airflow/blob/6686cf94924bc1397a1e21494025247873ef2234/Dockerfile#L192-L209
We can move all other variables to:
https://github.com/apache/airflow/blob/6686cf94924bc1397a1e21494025247873ef2234/Dockerfile#L209-L215
Thanks to this, we will have system dependencies and Airflow dependencies
separated by layers, so these layers will be invalidated much less frequently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
