potiuk commented on a change in pull request #19189:
URL: https://github.com/apache/airflow/pull/19189#discussion_r737969733



##########
File path: airflow/operators/python.py
##########
@@ -338,6 +347,7 @@ def __init__(
         python_version: Optional[Union[str, int, float]] = None,
         use_dill: bool = False,
         system_site_packages: bool = True,
+        clone_airflow_virtualenv: bool = True,

Review comment:
       And BTW. The current behaviour was rather different when someone had  
Airflow installed via `venv` already. 
   
   In this case no matter what you did - there was never `airflow` in your new 
virtualenv- no matter whether you used `system_site_packages` or not. (Unless 
airflow was ALSO installed as system package and you use dsystem_site_packages 
= True). 
   
   So here default expectation was that `airflow` is NOT installed even if 
system_site_packages were set to true.
   
   Messy is understatement.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to