potiuk commented on a change in pull request #19189:
URL: https://github.com/apache/airflow/pull/19189#discussion_r738140499



##########
File path: airflow/operators/python.py
##########
@@ -338,6 +347,7 @@ def __init__(
         python_version: Optional[Union[str, int, float]] = None,
         use_dill: bool = False,
         system_site_packages: bool = True,
+        clone_airflow_virtualenv: bool = True,

Review comment:
       I thought about and slept over it. I think I am going to come-up with a 
document (in docstring/.rst) which summarize the behaviour of PythonVirtualenv 
depending on the different parameters and environments. Before and after the 
change. 
   
   It might be easier to reason about any changes to it  and I think we need it 
to understand all the consequences.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to