potiuk commented on a change in pull request #20200:
URL: https://github.com/apache/airflow/pull/20200#discussion_r772273368
##########
File path: .github/workflows/build-images.yml
##########
@@ -224,7 +224,7 @@ jobs:
rm -rf "scripts/ci"
mv "main-airflow/scripts/ci" "scripts"
- name: "Free space"
- run: ./scripts/ci/tools/free_space.sh
+ run: ./scripts/ci/tools/freespace.py
Review comment:
I think you also need to add `run: pip install ./dev/breeze` as the
next step.
Also I think we could to one more thing - the "free_space.py" script shoudl
be moved to `./dev/breeze/ci` (and basically all other python scripts. This way
we will keep them as part of the "Breeze" package, we will keep some common
dependencies and it will be possible to reuse the code from breeze - for
example what @Bowrna is adding now is the util "run_command", and if you move
"free_space.py" part of the breeze package, the common utils will be reusble.
##########
File path: .github/workflows/build-images.yml
##########
@@ -224,7 +224,7 @@ jobs:
rm -rf "scripts/ci"
mv "main-airflow/scripts/ci" "scripts"
- name: "Free space"
- run: ./scripts/ci/tools/free_space.sh
+ run: ./scripts/ci/tools/freespace.py
Review comment:
I think you also need to add `run: pip install ./dev/breeze` as the
next step.
Also I think we could to one more thing - the "free_space.py" script shoudl
be moved to `./dev/breeze/ci` (and basically all other python scripts. This way
we will keep them as part of the "Breeze" package, we will keep some common
dependencies and it will be possible to reuse the code from breeze - for
example what @Bowrna is adding now is the util "run_command", and if you move
"free_space.py" part of the breeze package, the common utils will be reusable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
