potiuk commented on a change in pull request #20200:
URL: https://github.com/apache/airflow/pull/20200#discussion_r776347002



##########
File path: .github/workflows/ci.yml
##########
@@ -242,10 +242,6 @@ jobs:
     name: Breeze2 tests
     runs-on: ${{ fromJson(needs.build-info.outputs.runsOn) }}
     needs: [build-info]
-    defaults:
-      run:
-        shell: bash
-        working-directory: ./dev/breeze

Review comment:
       And one more thing - > In this case you actually need to also make sure 
that "dev/breeze" is installed. It used to be doneby working-directory but now 
I tihnk it's better to keep it consistent with other steps. Few lines below 
something like that should do - first line will install the dependencies from 
the right place, and second line will run pytest tests in the righ directory.
   
   ```
         - run: pip install ./dev/breeze 
         - run: python3 -m pytest -n auto --color=yes
           working-directory: ./dev/breeze
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to