potiuk commented on a change in pull request #20200:
URL: https://github.com/apache/airflow/pull/20200#discussion_r772277212
##########
File path: .github/workflows/build-images.yml
##########
@@ -297,7 +301,11 @@ jobs:
rm -rf "scripts/ci"
mv "main-airflow/scripts/ci" "scripts"
- name: "Free space"
- run: ./scripts/ci/tools/free_space.sh
+ run: ./scripts/ci/tools/freespace.py
Review comment:
Hmm. I think also this way it won't work. I think you cannot combine
"run" and "setup-python" actions in single step.
Those should be separate steps in the job.
Those two shoudl be run once at the beginning of each job:
1) setup_python (with pip cache)
2) run: pip install "./dev/breeze" - to install the dependenices
Then the "free_space.py" (and any future steps like this) could be run as
the next steps in the same job.
* run: free_space.py
* run: build_image.py (in the future)
* ....
This way the "initial" steps are setting up python virtualenv (with caching)
and install the right dependencies (such as rich) once and all the follow-up
run methods will have the "python" virtual environment prepared and with the
right depenencies installed (and the "pip" caching of setup-python is really
nice because it will keep the dependencies in a cache which means that in most
cases this environment creation as initial steps of the job will be very fast).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
