potiuk commented on a change in pull request #19572:
URL: https://github.com/apache/airflow/pull/19572#discussion_r774643843
##########
File path: airflow/providers/cncf/kubernetes/CHANGELOG.rst
##########
@@ -19,6 +19,19 @@
Changelog
---------
+3.0.0
+.....
+
+Breaking changes
+~~~~~~~~~~~~~~~~
+
+* ``Simplify KubernetesPodOperator (#19572)``
+
+.. warning:: Many methods in :class:`~.KubernetesPodOperator` and
class:`~.PodLauncher` have been renamed.
+ If you have subclassed :class:`~.KubernetesPodOperator` will need to
update your subclass to reflect
+ the new structure. Additionally ``PodStatus`` enum has been renamed to
``PodPhase``.
Review comment:
Maybe simply add a table with renamed methods to the Changelog? We've
done such things when we made breaking changes to Google Provider: - for
example here:
https://github.com/apache/airflow/blob/main/airflow/providers/google/CHANGELOG.rst#200
Another thought - maybe there is a way we could detect it - for example
implement a MetaClass for KPO that would fire when a new sub-class of KPO is
created and would check if the class has any of the renamed methods (and either
raise a warning or fail instantiation of such class - with link to the
CHANGELOG entry.
I think it should not be difficult to implement and it would be "as good as
it can be". I can take a look at implementing that after Xmas.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
