potiuk commented on a change in pull request #19572:
URL: https://github.com/apache/airflow/pull/19572#discussion_r776052141
##########
File path: airflow/providers/cncf/kubernetes/CHANGELOG.rst
##########
@@ -19,6 +19,19 @@
Changelog
---------
+3.0.0
+.....
+
+Breaking changes
+~~~~~~~~~~~~~~~~
+
+* ``Simplify KubernetesPodOperator (#19572)``
+
+.. warning:: Many methods in :class:`~.KubernetesPodOperator` and
class:`~.PodLauncher` have been renamed.
+ If you have subclassed :class:`~.KubernetesPodOperator` will need to
update your subclass to reflect
+ the new structure. Additionally ``PodStatus`` enum has been renamed to
``PodPhase``.
Review comment:
I've made the inventory (GitHub Issues and SO issues):
https://gist.github.com/potiuk/0c686cc712bc606323d1e78dd7f9dac2
Out of 41 issues I found, only one mentioned extending KPO as a solution:
https://stackoverflow.com/questions/66970409/passing-serviceaccount-in-airflow-kubernetes-pod-operator
It seems like a nasty workround (that actually could be solved by using an
undocumented feature of KPO at that time). I am convinced we do not need to
anything more than you did @dstandish .
BTW. Honourable mention goes to @kaxil for this answer:
https://stackoverflow.com/a/63164579/516701 which I found during making the
inventory. I thought I provide some of the longest (but accurate) answers on SO
but I think Kaxil beat me to it :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
