potiuk commented on a change in pull request #19572:
URL: https://github.com/apache/airflow/pull/19572#discussion_r774693498
##########
File path: airflow/providers/cncf/kubernetes/CHANGELOG.rst
##########
@@ -19,6 +19,19 @@
Changelog
---------
+3.0.0
+.....
+
+Breaking changes
+~~~~~~~~~~~~~~~~
+
+* ``Simplify KubernetesPodOperator (#19572)``
+
+.. warning:: Many methods in :class:`~.KubernetesPodOperator` and
class:`~.PodLauncher` have been renamed.
+ If you have subclassed :class:`~.KubernetesPodOperator` will need to
update your subclass to reflect
+ the new structure. Additionally ``PodStatus`` enum has been renamed to
``PodPhase``.
Review comment:
Yep. I thought it will be equally simple :). And I would not worry about
extending. If someone extends the class they can always change the name, add
underscorre or even (if we store the bad attrs as KPO class variable) - modify
the variable for their derirved class. Plenty of options (and we can even
suggest those options in the error we raise).
BTW. Re: table - it does not have to be perfect and 1-1. Even if we do not
know how to do the conversion just explicitly telling the user that we do not
know, it's not easy and they should dig deeper on their own - it's more than
enough.
What is important is that we do not leave the users alone in the dark. If
they got information that they need to dig throught the code on their own, we
avoid (most of the time) the inevitable question on our slack "I got this
error ? What should I do?". And even if we do not avoid the question being
asked (some users would do that even if they got BIG RED DESCRIPTION straight
in their logs) we can always simply respontd: "Please red the BIG RED
DESCRIPTION" you see in the log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
