ashb commented on a change in pull request #20795:
URL: https://github.com/apache/airflow/pull/20795#discussion_r783014315
##########
File path: airflow/utils/log/logging_mixin.py
##########
@@ -73,11 +73,23 @@ def supports_external_link(self) -> bool:
"""Return whether handler is able to support external links."""
-class StreamLogWriter(IOBase):
+class StreamLogWriter(IO[str], IOBase):
"""Allows to redirect stdout and stderr to logger"""
encoding: None = None
+ def fileno(self) -> int:
Review comment:
I thought so too but it complained without it -- this was mostly around
the use in StdoutRedirector which wants this to be `IO[str]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
